Fix unknown function in tests for checkbox-support (bugfix)#958
Merged
Fix unknown function in tests for checkbox-support (bugfix)#958
Conversation
Hook25
changed the title
kissiel
approved these changes
Jan 22, 2024
Contributor
kissiel
left a comment
kissiel
left a comment
There was a problem hiding this comment.
makes sense, +1
(I wonder if toxxing will choke on it or not)
LiaoU3
pushed a commit
to LiaoU3/checkbox
that referenced
this pull request
Mar 20, 2024
…l#958) * Fixed unknown method name in checkbox-support test * Called once with counts before filtering
binli
pushed a commit
to binli/checkbox
that referenced
this pull request
Mar 22, 2024
…l#958) * Fixed unknown method name in checkbox-support test * Called once with counts before filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running via the deb runner, this test fails on python 3.12. This should always fail and the reason why it doesn't is still unclear to me at this point. The function name is wrong and it should be
assert_called_once_withThis updates every test with the correct function call.
Resolved issues
Resolves: https://launchpadlibrarian.net/710488943/buildlog_ubuntu-noble-amd64.checkbox-support_3.3.0~dev96~ubuntu24.04.1_BUILDING.txt.gz
Documentation
N/A
Tests
N/A